1. ホーム
  2. 質問と答え
  3. if/elseブロック目的-cの問題iPhone

if/elseブロック目的-cの問題iPhone

2012-03-13 22 views
-4

私のラベルとイメージビューに値を割り当てるのに、以下のコードを使用していますが、正しく動作しません。私は、あなたが実際の問題文が間違っていることがある場合は何であるか言っていない問題if/elseブロック目的-cの問題iPhone

if ([child11 length] != 0) { 
    [childButton1 setAlpha:1]; 
    [childButton2 setAlpha:0]; 
    [childButton3 setAlpha:0]; 
    [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; 
    [childButton6 setAlpha:0]; 
    //label1.text = child11; 
    NSLog(@"here we are"); 

    if ([child11image isEqualToString:@"Fajar"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
     NSLog(@"child11image::: %@", child11image); 
     label1.text = child11; 
    } else if ([child11image isEqualToString:@"Zuhr"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
     label1.text = child11; 
    } else if ([child11image isEqualToString:@"Asr"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Large"]]; 
     label1.text = child11; 
     NSLog(@"child11image::: %@", child11image); 
    } else if ([child11image isEqualToString:@"Maghrib"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
     label1.text = child11; 
    } else if ([child11image isEqualToString:@"Isha"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
     label1.text = child11; 
    } 
} else if ([child22 length] != 0){ 
    [childButton1 setAlpha:1]; 
    [childButton2 setAlpha:1]; 
    [childButton3 setAlpha:0]; 
    [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; 
    [childButton6 setAlpha:0]; 
    label2.text = child22; 

    if ([child22image isEqualToString:@"Fajar"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Zuhr"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Asr"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Maghrib"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Isha"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child33 length] != 0){ 
    [childButton1 setAlpha:1]; 
    [childButton2 setAlpha:1]; 
    [childButton3 setAlpha:1]; 
    [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; 
    [childButton6 setAlpha:0]; 

    label3.text = child33; 

    if ([child33image isEqualToString:@"Fajar"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Zuhr"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Asr"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Maghrib"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Isha"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child44 length] != 0) { 
    [childButton1 setAlpha:1]; 
    [childButton2 setAlpha:1]; 
    [childButton3 setAlpha:1]; 
    [childButton4 setAlpha:1]; 
    [childButton5 setAlpha:0]; 
    [childButton6 setAlpha:0]; 

    label4.text = child44; 

    if ([child44image isEqualToString:@"Fajar"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Zuhr"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Asr"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Maghrib"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Isha"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child55 length] != 0) { 
    [childButton1 setAlpha:1]; 
    [childButton2 setAlpha:1]; 
    [childButton3 setAlpha:1]; 
    [childButton4 setAlpha:1]; 
    [childButton5 setAlpha:1]; 
    [childButton6 setAlpha:0]; 

    label5.text = child55; 

    if ([child55image isEqualToString:@"Fajar"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Zuhr"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Asr"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Maghrib"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Isha"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child66 length] != 0) { 
    [childButton1 setAlpha:1]; 
    [childButton2 setAlpha:1]; 
    [childButton3 setAlpha:1]; 
    [childButton4 setAlpha:1]; 
    [childButton5 setAlpha:1]; 
    [childButton6 setAlpha:1]; 

    label6.text = child66; 

    if ([child66image isEqualToString:@"Fajar"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Zuhr"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Asr"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Maghrib"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Isha"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else ([child11 length] == 0) { 
    [childButton1 setAlpha:0]; 
    [childButton2 setAlpha:0]; 
    [childButton3 setAlpha:0]; 
    [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; 
    [childButton6 setAlpha:0]; 
}

出典

2012-03-13 Omer Waqas Khan

+3

こんにちは、ご希望の実際の結果は何ですか？ここで何がうまくいかないかを判断するのに役立ちます。 –

+3

また、これはひどいコードです！ ：D – jtbandes

+4

@jtbandes正確に何が間違っていますか？批判するだけではなく、教えてください。 :) –

答えて

2

を取得しておりません。最初の2つの条件はあなたが常にあるため(x == 0 || x != 0) == true定義で最初の2例1を通過します

if ([child11 length] == 0) 
{ 
    // do stuff 
} 
else if ([child11 length] != 0) 
{ 
    // do stuff 
} 
else // nothing else matters

です。 child22、child33などと関係するものはすべて決して終わらない。

出典

2012-03-13 16:33:48 JeremyP

+0

コードを変更しました。if（[child11 length] == 0）という部分が最後にelseとして割り当てられています。 –

0

[child11 length] != 0の場合は、他のチェックを行うことはありません。 （私は。child11とchild22が非空にすることができ

を推測していますそして、あなたはあなたのコードを改善しなければならない！基本のiPhoneアプリの例を学ぶことから始め、すべてのネットワークに広がる。

出典

2012-03-13 16:35:32 giorashc

1

私は、これはあなたが

何を意味するかだと思います 
if ([child11 length] != 0){ 
    [childButton1 setAlpha:1]; [childButton2 setAlpha:0]; [childButton3 setAlpha:0]; [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; [childButton6 setAlpha:0]; 
    label1.text = child11; 
    if ([child11image isEqualToString:@"Fajar"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]];   
    } else if ([child11image isEqualToString:@"Zuhr"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child11image isEqualToString:@"Asr"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Large"]]; 
    } else if ([child11image isEqualToString:@"Maghrib"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child11image isEqualToString:@"Isha"]) { 
     image1 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child22 length] != 0){ 
    [childButton1 setAlpha:1]; [childButton2 setAlpha:1]; [childButton3 setAlpha:0]; [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; [childButton6 setAlpha:0]; 
    label2.text = child22; 

    if ([child22image isEqualToString:@"Fajar"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Zuhr"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Asr"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Maghrib"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child22image isEqualToString:@"Isha"]) { 
     image2 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child33 length] != 0){ 
    [childButton1 setAlpha:1]; [childButton2 setAlpha:1]; [childButton3 setAlpha:1]; [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; [childButton6 setAlpha:0]; 
    label3.text = child33; 

    if ([child33image isEqualToString:@"Fajar"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Zuhr"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Asr"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Maghrib"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child33image isEqualToString:@"Isha"]) { 
     image3 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child44 length] != 0){ 
    [childButton1 setAlpha:1]; [childButton2 setAlpha:1]; [childButton3 setAlpha:1]; [childButton4 setAlpha:1]; 
    [childButton5 setAlpha:0]; [childButton6 setAlpha:0]; 
    label4.text = child44; 

    if ([child44image isEqualToString:@"Fajar"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Zuhr"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Asr"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Maghrib"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child44image isEqualToString:@"Isha"]) { 
     image4 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child55 length] != 0){ 
    [childButton1 setAlpha:1]; [childButton2 setAlpha:1]; [childButton3 setAlpha:1]; [childButton4 setAlpha:1]; 
    [childButton5 setAlpha:1]; [childButton6 setAlpha:0]; 
    label5.text = child55; 

    if ([child55image isEqualToString:@"Fajar"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Zuhr"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Asr"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Maghrib"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child55image isEqualToString:@"Isha"]) { 
     image5 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else if ([child66 length] != 0){ 
    [childButton1 setAlpha:1]; [childButton2 setAlpha:1]; [childButton3 setAlpha:1]; [childButton4 setAlpha:1]; 
    [childButton5 setAlpha:1]; [childButton6 setAlpha:1]; 
    label6.text = child66; 

    if ([child66image isEqualToString:@"Fajar"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Blue-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Zuhr"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Orange-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Asr"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Pink-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Maghrib"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Green-Jaanamaz-Small"]]; 
    } else if ([child66image isEqualToString:@"Isha"]) { 
     image6 = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"Purple-Jaanamaz-Small"]]; 
    } 
} else { 
    [childButton1 setAlpha:0]; [childButton2 setAlpha:0]; [childButton3 setAlpha:0]; [childButton4 setAlpha:0]; 
    [childButton5 setAlpha:0]; [childButton6 setAlpha:0]; 
}

私はこのコードは条件がif ([child11 length] == 0)のように発生している場合見つけ、問題とif ([child11 length] !=0)childButton1、childButton2setAlpha:は1になります。私はあなたがをしなければならないと思います上記の条件が発生する場合、0とchildButton2 setAlphaを1とします。私はあなたが正確に必要なものを知りません

そして一つ。 このようなコードは書かないでください。スイッチのケースとエニュメントを使用して、コードの可読性とパフォーマンスを向上させます。ハッピーコーディング。

出典

2012-03-13 17:11:06

+0

実際に私がしようとしていたのは、最初の条件が満たされていない場合、2番目の条件が満たされない場合です。私はchild11に何らかの価値があるとしようとしていましたが、最初の状態にあるものは何でも、今度はchild22が値を持ち次の条件を実行する次の時間を行っています。私はこれを達成する方法を知らない。 Child11、child22 ....これらはNSUserDefaultsに保存された値です...あなたはそれを手伝ってくれますか？ –

関連する問題

 関連する問題