我々は助けを必要と...私はちょうど下のではなく、作業をしてみました以下のコード行をどのように改善できますか?
if ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType != DeviceType.UnKnown)).Count() > 0)
{
//l_Subscription.DeviceTypeID = ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType == DeviceType.Tablet)).Count() > 0)?()
if ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType == DeviceType.Tablet)).Count() > 0)
l_Subscription.DeviceTypeID = (int)DeviceType.Tablet;
else if ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType == DeviceType.Phone)).Count() > 0)
l_Subscription.DeviceTypeID = (int)DeviceType.Phone;
}
のコード行を向上させることができます
int cnt = DoOperation(l_Subscription.PackageInfo.Applications, x => x.DeviceType != DeviceType.UnKnown);
if(cnt > 0)
{
int cnt1 = DoOperation(l_Subscription.PackageInfo.Applications, x => x.DeviceType == DeviceType.Tablet);
int cnt2 = DoOperation(l_Subscription.PackageInfo.Applications, x => x.DeviceType == DeviceType.Phone);
if(cnt1 > 0) l_Subscription.DeviceTypeID = (int)DeviceType.Tablet;
else if (cnt2 > 0) l_Subscription.DeviceTypeID = (int)DeviceType.Phone;
}
private int DoOperation<TKey>(List<l_Subscription.PackageInfo.Applications> list, Func<l_Subscription.PackageInfo.Applications, TKey> predicate)
{
int count = 0;
count = list.Where(predicate).Count();
return count;
}
私は8行を1つではなく数えます。あなたはそれについて何を "改善"したいですか? – Oded
もっと良い方法を書いて – user1025901