C＃ - Linqで条件がwhere句の条件を選択した場合

Question

どうすれば避けることができますか？

if (Userid == 0) 
{ 
    var logList = service.GetLogDetails(); 
    var usernames = (from A in logList orderby A.FirstName select new { Name = A.FirstName + " " + A.SurName, ID = A.Id }).Distinct(); 
    var loginDate = (from A in logList select A.LogInTime.Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries)).Distinct(); 
    var logOutDate = (from A in logList select (A.LogOutTime ?? "Unknown").ToString().Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries)).Distinct(); 
} 
else 
{ 
    var logList = service.GetLogDetails(); 
    var usernames = (from A in logList where A.Id == Userid orderby A.FirstName select new { Name = A.FirstName + " " + A.SurName, ID = A.Id }).Distinct(); 
    var loginDate = (from A in logList where A.Id == Userid select A.LogInTime.Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries)).Distinct(); 
    var logOutDate = (from A in logList where A.Id == Userid select (A.LogOutTime ?? "Unknown").ToString().Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries)).Distinct(); 
} 

Answer 1

where句をLINQあなたに||を使用してください。また、あなたは一度logListを照会し、それに異なる投影を適用することにより、改善することができます。

var logList = service.GetLogDetails() 
        .Where(item => Userid == 0 || item.Id = Userid) 
        .ToList(); 

var usernames = (from A in logList 
       orderby A.FirstName 
       select new { Name = $"{A.FirstName} {A.SurName}", ID = A.Id }).Distinct(); 

var loginDate = (from A in logList 
       select A.LogInTime.Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries)).Distinct(); 

var logOutDate = (from A in logList 
        select (A.LogOutTime ?? "Unknown").ToString().Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries)).Distinct(); 

Answer 2

をこの

var usernames = (from A in logList where A.Id = UserId || UserId == 0 ...