2016-07-12 40 views
0

私はPythonプログラミングの本を使って作業しており、そのうちの1つにブラックジャックゲームがあります。私はプログラムでエラーを見つけてそれを処理するためにこの演習を行っています。 1つのエラーの1つは、1から7の範囲の数のプレーヤーを求めているということです。理論的には、このゲームでは最大7人のプレイヤーを持つことができます。しかし、私はプログラムを実行するときに私は1つ以上のプレーヤーを追加することができません。私が1以外の数字を欲しいと言ったら、それはちょうどその質問を繰り返す。Python - ブラックジャックのゲームが1人以上のプレーヤーを獲得していない

# Games 
 
# Demonstrates module creation 
 

 

 
class Player(object): 
 
    """ A Player for the game """ 
 
    def __init__(self, name, score=0): 
 
     self.name = name 
 
     self.score = score 
 

 
    def __str__(self): 
 
     rep = self.name + ":\t" + str(self.score) 
 
     return rep 
 

 

 
def ask_yes_no(question): 
 
    """ Ask a yes or no question """ 
 
    response = None 
 
    while response not in ("y", "n"): 
 
     response = input(question).lower() 
 
    return response 
 

 

 
def ask_number(question, low, high): 
 
    """ Ask for a number within a range """ 
 
    response = None 
 
    while response not in (low, high): 
 
     response = int(input(question)) 
 
    return response 
 

 
if __name__ == "__main__": 
 
    print("You ran this module directly (and did not 'import' it).") 
 
    input("\n\nPress the ENTER key to exit.")

そして、ここで私がから上記のいずれかを呼び出すこと午前モジュールである:ここでは

は私がはい/いいえと数の質問をgamesモジュールであります

# Blackjack 
 
# From 1 to 7 players compete against a dealer 
 
import python_programming_absolute_beginner.chapter_9.cards as cards 
 
import python_programming_absolute_beginner.chapter_9.games as games 
 

 

 
class BlackjackCard(cards.Card): 
 
    """ A Blackjack Card """ 
 
    ACE_VALUE = 1 
 

 
    @property 
 
    def value(self): 
 
     value = BlackjackCard.RANKS.index(self.rank) + 1 
 
     if self.is_face_up: 
 
      if value > 10: 
 
       value = 10 
 
     else: 
 
      value = None 
 
     return value 
 

 

 
class BlackjackDeck(cards.Deck): 
 
    """ A Blackjack Deck """ 
 

 
    def populate(self): 
 
     for suit in BlackjackCard.SUITS: 
 
      for rank in BlackjackCard.RANKS: 
 
       self.cards.append(BlackjackCard(rank, suit)) 
 

 

 
class BlackjackHand(cards.Hand): 
 
    """ A Blackjack Hand """ 
 
    def __init__(self, name): 
 
     super(BlackjackHand, self).__init__() 
 
     self.name = name 
 

 
    def __str__(self): 
 
     rep = self.name + ":\t" + super(BlackjackHand, self).__str__() 
 
     if self.total: 
 
      rep += "(" + str(self.total) + ")" 
 
     return rep 
 

 
    @property 
 
    def total(self): 
 
     # if a card in the hand has a value of None, then total is None 
 
     for card in self.cards: 
 
      if not card.value: 
 
       return None 
 

 
     # add up card values, treat each Ace as 1 
 
     t = 0 
 
     for card in self.cards: 
 
      t += card.value 
 

 
     # determine if hand contains an Ace 
 
     contains_ace = False 
 
     for card in self.cards: 
 
      if card.value == BlackjackCard.ACE_VALUE: 
 
       contains_ace = True 
 

 
     # if hand contains Ace and total is low enough treat Ace as an 11 
 
     if contains_ace and t <= 11: 
 
      # add only 10 since we've already added 1 for the Ace 
 
      t += 10 
 
     return t 
 

 
    def is_busted(self): 
 
     return self.total > 21 
 

 

 
class BlackjackPlayer(BlackjackHand): 
 
    """ A Blackjack Player """ 
 
    def is_hitting(self): 
 
     response = \ 
 
      games.ask_yes_no("\n" + self.name + ", do you want a hit? (Y/N): ") 
 
     return response == "y" 
 

 
    def bust(self): 
 
     print(self.name, "busts.") 
 
     self.lose() 
 

 
    def lose(self): 
 
     print(self.name, "loses.") 
 

 
    def win(self): 
 
     print(self.name, "wins.") 
 

 
    def push(self): 
 
     print(self.name, "pushes.") 
 

 

 
class BlackjackDealer(BlackjackHand): 
 
    """ A Blackjack Dealer """ 
 
    def is_hitting(self): 
 
     return self.total < 17 
 

 
    def bust(self): 
 
     print(self.name, "busts.") 
 

 
    def flip_first_card(self): 
 
     first_card = self.cards[0] 
 
     first_card.flip() 
 

 

 
class BlackjackGame(object): 
 
    """ A Blackjack Game """ 
 
    def __init__(self, names): 
 
     self.players = [] 
 
     for name in names: 
 
      player = BlackjackPlayer(name) 
 
      self.players.append(player) 
 

 
     self.dealer = BlackjackDealer("Dealer") 
 
     self.deck = BlackjackDeck() 
 
     self.deck.populate() 
 
     self.deck.shuffle() 
 

 
     # Check the card count, and if it is less than 10 repopulate and 
 
     # reshuffle 
 

 
    @property 
 
    def still_playing(self): 
 
     sp = [] 
 
     for player in self.players: 
 
      if not player.is_busted(): 
 
       sp.append(player) 
 
     return sp 
 

 
    def __additional_cards(self, player): 
 
     while not player.is_busted() and player.is_hitting(): 
 
      self.deck.deal([player]) 
 
      print(player) 
 
      if player.is_busted(): 
 
       player.bust() 
 

 
    def play(self): 
 
     # deal initial 2 cards to everyone 
 
     self.deck.deal(self.players + [self.dealer], per_hand=2) 
 
     self.dealer.flip_first_card() # hide dealer's first card 
 
     for player in self.players: 
 
      print(player) 
 
     print(self.dealer) 
 

 
     # deal additional cards to players 
 
     for player in self.players: 
 
      self.__additional_cards(player=player) 
 

 
     self.dealer.flip_first_card() # reveal the dealer's first card 
 

 
     if not self.still_playing: 
 
      # since all players have busted, just show the dealer's hand 
 
      print(self.dealer) 
 
     else: 
 
      # deal additional cards to dealer 
 
      print(self.dealer) 
 
      self.__additional_cards(self.dealer) 
 

 
      if self.dealer.is_busted(): 
 
       # everyone still playing wins 
 
       for player in self.still_playing: 
 
        player.win() 
 
      else: 
 
       # compare each player still playing to the dealer 
 
       for player in self.still_playing: 
 
        if player.total > self.dealer.total: 
 
         player.win() 
 
        elif player.total < self.dealer.total: 
 
         player.lose() 
 
        else: 
 
         player.push() 
 

 
     # remove everyone's cards 
 
     for player in self.players: 
 
      player.clear() 
 
     self.dealer.clear() 
 

 

 
def main(): 
 
    print("\t\tWelcome to Blackjack!") 
 
    names = [] 
 
    number = games.ask_number("How many players? (1 - 7): ", low=1, high=8) 
 
    for i in range(number): 
 
     name = input("Enter player name: ") 
 
     names.append(name) 
 
     print() 
 
     game = BlackjackGame(names) 
 

 
     again = None 
 
     while again != "n": 
 
      game.play() 
 
      again = games.ask_yes_no("\nDo you want to play again?: ") 
 

 
main() 
 
input("\n\nPress the ENTER key to exit.")

なぜこれが7人ではなく1人のプレイヤーしか許可していないのですか?

答えて

3

while response not in (low, high) #It checks if variable response equals only 1 or 8. 

は、それを変更してみてください不適切なインデント。

あなたは最初のプレイヤーが入力された後、これはすぐにゲームを開始します

def main(): 
    print("\t\tWelcome to Blackjack!") 
    names = [] 
    number = games.ask_number("How many players? (1 - 7): ", low=1, high=8) 
    for i in range(number): 
     name = input("Enter player name: ") 
     names.append(name) 
     print() 
     #still in the loop, game starts now with first player 
     game = BlackjackGame(names) 

     again = None 
     while again != "n": 
      game.play() 
      again = games.ask_yes_no("\nDo you want to play again?: ") 

を持っています。

forループの本体にプレーヤーを追加するだけで、すべてのプレーヤーが追加された後でゲームを開始するようにします。

コードは次のようになります。私はしたいですどのように多くの選手質問をしてからそれを停止し、それが唯一のゲームが開始する前に、私は一人のプレイヤー名を入力することができ

def main(): 
    print("\t\tWelcome to Blackjack!") 
    names = [] 
    number = games.ask_number("How many players? (1 - 7): ", low=1, high=8) 
    for i in range(number): 
     name = input("Enter player name: ") 
     names.append(name) 
     print() 

    #only start the game after all players are added 
    game = BlackjackGame(names) 

    again = None 
    while again != "n": 
     game.play() 
     again = games.ask_yes_no("\nDo you want to play again?: ") 
+0

ありがとうございます。これはうまくいった。 – DarthOpto

1

私はそれを見ると、このコード行で問題があります:あなたのメインのループ内の論理エラーが原因であり

while response not in range(low, high) #This checks if variable response equals any number between 1 and 8 
+0

[OK]をクリックします。私はまた、 'main'メソッドに問題があると考えています。 – DarthOpto

関連する問題